Independent wkhtmltopdf#494
Open
amon-ra wants to merge 3 commits into
Open
Conversation
Contributor
|
Forgive me if I’m wrong, as I’m reading this PR on my phone, but this looks like a major breaking change? As a very grateful user of Doodba, I like the idea of this in theory, but if it could be opt in and keep the existing functionality I feel it would be much more likely to be merged… |
amon-ra
force-pushed
the
remote-wkhtmltopdf
branch
from
9034ff4 to
7010668
Compare
Author
|
Now you can use build arg WKHTMLTOPDF_SKIP=1 to skip wkhtmltopdf build and use the new binary, there are no breaking changes now |
|
@amon-ra Can you re-trigger tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull try to solve Tecnativa/doodba#4039 . It will load wkhtmltopdf from an external docker image in port 8080.